Handle truncated start login frame (#400)

This commit is contained in:
Geoff Bourne
2025-04-26 21:24:41 -05:00
committed by GitHub
parent 4ba55a9ccd
commit 419692825e
3 changed files with 24 additions and 13 deletions
+2 -2
View File
@@ -55,12 +55,12 @@ func DecodeLoginStart(data interface{}) (*LoginStart, error) {
loginStart.Name, err = ReadString(buffer)
if err != nil {
return nil, errors.Wrap(err, "failed to read username")
return loginStart, errors.Wrap(err, "failed to read username")
}
loginStart.PlayerUuid, err = ReadUuid(buffer)
if err != nil {
return nil, errors.Wrap(err, "failed to read player uuid")
return loginStart, errors.Wrap(err, "failed to read player uuid")
}
return loginStart, nil
+4 -2
View File
@@ -1,3 +1,5 @@
// Package mcproto provides functions to read types and decode frames declared
// at https://minecraft.wiki/w/Java_Edition_protocol
package mcproto
import (
@@ -27,7 +29,7 @@ const MaxFrameLength = 2097151
func ReadPacket(reader *bufio.Reader, addr net.Addr, state State) (*Packet, error) {
logrus.
WithField("client", addr).
Debug("Reading packet")
Trace("Reading packet")
if state == StateHandshaking {
data, err := reader.Peek(1)
@@ -158,7 +160,7 @@ func ReadUTF16BEString(reader io.Reader, symbolLen uint16) (string, error) {
func ReadFrame(reader io.Reader, addr net.Addr) (*Frame, error) {
logrus.
WithField("client", addr).
Debug("Reading frame")
Trace("Reading frame")
var err error
frame := &Frame{}